support the visualization of the structure with VESTA #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
added
type/accepted feature
|
I have checked the PR locally and for me it works. Thank you very much @yw-fang for the useful contribution. @giovannipizzi I would merge, but would prefer you confirm. Even though I tested it to work I have no real experience with this part of the code |
giovannipizzi
approved these changes
Feb 2, 2018
|
Sure, I agree. Thanks very much for merging this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a feature to visualize the structure using VESTA. It worked well in my testing with v0.10.0 and v0.11.1. Now, in addition to Jmol, VMD, ase and XCrysden, we have this new choice. I think some colleagues will be happy to use it.